chromeos: Remove legacy code for chrome://imageburner

chromeos: Remove legacy code for chrome://imageburner

chrome://imageburner was replaced by the new recovery tool
http://google.com/chromeos/recovery.

With this change, chrome://imageburner just redirects to
the new recovery tool page.

Note that the D-Bus client code (ImageBurnerClient) is not removed
because it's used in imageWriterPrivate API, used in the new
recovery tool.

BUG=344279
TEST=open chrome://imageburner and you are redirected to http://google.com/chromeos/recovery

Committed: https://crrev.com/6ef2a8be7279319b1b98fbbb82acb1dff53fc065
Cr-Commit-Position: refs/heads/master@{#302042}

[satorux1, 2014-10-24 06:45:42]

satorux@chromium.org changed reviewers:
+ jhawkins@chromium.org, oshima@chromium.org, tbarzic@chromium.org

[satorux1, 2014-10-24 06:45:43]

oshima: chrome/browser/chromeos
jhawkins: chrome/browser/resources, chrome/browser/ui
tbarzic: FYI

[oshima, 2014-10-24 10:49:24]

lgtm

[tbarzic, 2014-10-24 22:50:30]

On 2014/10/24 10:49:24, oshima wrote:
> lgtm

lgtm

[satorux1, 2014-10-27 05:12:12]

jhawkins: ping

[James Hawkins, 2014-10-27 16:13:28]

https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/image_burner.html (right):

https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/image_burner.html:5:
content="0;url=http://google.com/chromeos/recovery">
How long are we planning to keep this WebUI link available?

https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/image_burner.html:5:
content="0;url=http://google.com/chromeos/recovery">
What happens if the user attempts to navigate here with no connection?

[satorux1, 2014-10-28 05:07:42]

https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/image_burner.html (right):

https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/image_burner.html:5:
content="0;url=http://google.com/chromeos/recovery">
On 2014/10/27 16:13:28, James Hawkins wrote:
> What happens if the user attempts to navigate here with no connection?

The user will see "Unable to connect to the Internet" page, which is not ideal,
but should be acceptable, as users should rarely reach to this page. FWIW, the
PM suggested to do a simple redirect rather than to place explanatory text.

https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/image_burner.html:5:
content="0;url=http://google.com/chromeos/recovery">
On 2014/10/27 16:13:28, James Hawkins wrote:
> How long are we planning to keep this WebUI link available?

I think we can remove it in a year or so, but let me check with the PM. Once I
get an answer, I'll add a TODO comment about when to remove the page.

[satorux1, 2014-10-28 05:39:25]

On 2014/10/28 05:07:42, satorux1 wrote:
>
https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/image_burner.html (right):
> 
>
https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/image_burner.html:5:
> content="0;url=http://google.com/chromeos/recovery">
> On 2014/10/27 16:13:28, James Hawkins wrote:
> > What happens if the user attempts to navigate here with no connection?
> 
> The user will see "Unable to connect to the Internet" page, which is not
ideal,
> but should be acceptable, as users should rarely reach to this page. FWIW, the
> PM suggested to do a simple redirect rather than to place explanatory text.
> 
>
https://codereview.chromium.org/679633002/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/image_burner.html:5:
> content="0;url=http://google.com/chromeos/recovery">
> On 2014/10/27 16:13:28, James Hawkins wrote:
> > How long are we planning to keep this WebUI link available?
> 
> I think we can remove it in a year or so, but let me check with the PM. Once I
> get an answer, I'll add a TODO comment about when to remove the page.

Got the answer. We'll remove it 12 months from now. Added TODO comments.

[James Hawkins, 2014-10-28 22:34:21]

lgtm

[satorux1, 2014-10-29 01:22:53]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2014-10-29 01:24:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679633002/20001

[commit-bot: I haz the power, 2014-10-29 02:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-29 02:02:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[satorux1, 2014-10-30 05:30:03]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2014-10-30 05:31:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679633002/60001

[commit-bot: I haz the power, 2014-10-30 06:12:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-30 06:13:22]

Patchset 4 (id:??) landed as
https://crrev.com/6ef2a8be7279319b1b98fbbb82acb1dff53fc065
Cr-Commit-Position: refs/heads/master@{#302042}