Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 679623002: Check whether aria-expanded attribute is defined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update expanded API for AXMenuList Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXNodeObject.cpp
diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp
index 1140082d95d1d0efe228b4ba3fd2eb7612863ddc..1f7bbd496835d22b2646345829d089c1a1255acd 100644
--- a/Source/core/accessibility/AXNodeObject.cpp
+++ b/Source/core/accessibility/AXNodeObject.cpp
@@ -709,12 +709,15 @@ bool AXNodeObject::isEnabled() const
return !toElement(node)->isDisabledFormControl();
}
-bool AXNodeObject::isExpanded() const
+AccessibilityExpanded AXNodeObject::isExpanded() const
{
- if (equalIgnoringCase(getAttribute(aria_expandedAttr), "true"))
- return true;
+ const AtomicString& expanded = getAttribute(aria_expandedAttr);
+ if (equalIgnoringCase(expanded, "true"))
+ return ExpandedExpanded;
+ if (equalIgnoringCase(expanded, "false"))
+ return ExpandedCollapsed;
- return false;
+ return ExpandedUndefined;
}
bool AXNodeObject::isIndeterminate() const
@@ -1101,7 +1104,6 @@ String AXNodeObject::ariaDescribedByAttribute() const
return accessibilityDescriptionForElements(elements);
}
-
String AXNodeObject::ariaLabeledByAttribute() const
{
WillBeHeapVector<RawPtrWillBeMember<Element> > elements;

Powered by Google App Engine
This is Rietveld 408576698