Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: Source/core/accessibility/AXObject.h

Issue 679623002: Check whether aria-expanded attribute is defined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Introduce new enum for aria-expanded Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXObject.h
diff --git a/Source/core/accessibility/AXObject.h b/Source/core/accessibility/AXObject.h
index cf853a6b877e6954ee4e395ebbeaeccbfe9ef805..416244f1b99d5a2a8d8c7a1d447d3f16fcee8920 100644
--- a/Source/core/accessibility/AXObject.h
+++ b/Source/core/accessibility/AXObject.h
@@ -194,7 +194,6 @@ enum AccessibilityTextSource {
enum AccessibilityState {
AXBusyState,
AXCheckedState,
- AXCollapsedState,
AXEnabledState,
AXExpandedState,
AXFocusableState,
@@ -257,6 +256,12 @@ enum AccessibilityTextDirection {
AccessibilityTextDirectionBottomToTop
};
+enum AccessibilityExpanded {
+ ExpandedUndefined = 0,
+ ExpandedCollapsed,
+ ExpandedExpanded,
+};
+
class AXObject : public RefCounted<AXObject> {
public:
typedef Vector<RefPtr<AXObject> > AccessibilityChildrenVector;
@@ -365,7 +370,6 @@ public:
virtual bool isClickable() const;
virtual bool isCollapsed() const { return false; }
virtual bool isEnabled() const { return false; }
- virtual bool isExpanded() const { return false; }
virtual bool isFocused() const { return false; }
virtual bool isHovered() const { return false; }
virtual bool isIndeterminate() const { return false; }
@@ -429,6 +433,7 @@ public:
// ARIA attributes.
virtual AXObject* activeDescendant() const { return 0; }
virtual String ariaDescribedByAttribute() const { return String(); }
+ virtual AccessibilityExpanded ariaExpanded() const { return ExpandedUndefined; }
dmazzoni 2014/10/29 07:46:59 I think this should be called isExpanded or getExp
je_julie(Not used) 2014/10/29 13:07:27 I updated API name with isExpanded. On 2014/10/29
virtual void ariaFlowToElements(AccessibilityChildrenVector&) const { }
virtual void ariaControlsElements(AccessibilityChildrenVector&) const { }
virtual void ariaDescribedbyElements(AccessibilityChildrenVector& describedby) const { };

Powered by Google App Engine
This is Rietveld 408576698