Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/core/accessibility/AXNodeObject.h

Issue 679623002: Check whether aria-expanded attribute is defined (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Introduce new enum for aria-expanded Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXNodeObject.h
diff --git a/Source/core/accessibility/AXNodeObject.h b/Source/core/accessibility/AXNodeObject.h
index 38f4013bec78f9eef68670dce2191f38aed2c554..40f6800742d9bd7c5a806136559ab5df800a9ea0 100644
--- a/Source/core/accessibility/AXNodeObject.h
+++ b/Source/core/accessibility/AXNodeObject.h
@@ -113,7 +113,6 @@ protected:
virtual bool isChecked() const override final;
virtual bool isClickable() const override final;
virtual bool isEnabled() const override;
- virtual bool isExpanded() const override final;
virtual bool isIndeterminate() const override final;
virtual bool isPressed() const override final;
virtual bool isReadOnly() const override;
@@ -143,6 +142,8 @@ protected:
// ARIA attributes.
virtual String ariaDescribedByAttribute() const override final;
+ AccessibilityExpanded getExpandedAttr() const;
dmazzoni 2014/10/29 07:46:59 I'd do the opposite here - since this only returns
je_julie(Not used) 2014/10/29 13:07:27 I updated API name with isExpanded. On 2014/10/29
+ virtual AccessibilityExpanded ariaExpanded() const override;
virtual String ariaLabeledByAttribute() const override final;
virtual AccessibilityRole ariaRoleAttribute() const override final;

Powered by Google App Engine
This is Rietveld 408576698