Check whether aria-expanded attribute is defined

Source/core/accessibility/AXMenuList.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 69 matching lines @@
 
     ASSERT(m_children.size() == 1);
     m_children[0]->childrenChanged();
 }
 
 bool AXMenuList::isCollapsed() const
 {
     return !toRenderMenuList(m_renderer)->popupIsVisible();
 }
 
+AccessibilityExpanded AXMenuList::ariaExpanded() const
+{
+    AccessibilityExpanded expanded = getExpandedAttr();

[dmazzoni, 2014/10/29 07:46:59]

The ARIA spec says that ARIA shouldn't be allowed to override states that have
native semantics. So in this case, an AXMenuList is a native select element and
there's already a semantic meaning to whether it's expanded and collapsed, so
ARIA is not allowed to override it, that would only create confusion.

http://www.w3.org/TR/wai-aria-implementation/#mapping_conflicts

So basically I think this function should ignore the aria-expanded attribute and
just return whether the AXMenuList is really collapsed or expanded.

[je_julie(Not used), 2014/10/29 13:07:27]

Thanks for your comment. I updated it.
On 2014/10/29 07:46:59, dmazzoni wrote:

+
+    if (expanded)
+        return expanded;
+
+    if (isCollapsed())
+        return ExpandedCollapsed;
+
+    return ExpandedExpanded;
+}
+
 bool AXMenuList::canSetFocusAttribute() const
 {
     if (!node())
         return false;
 
     return !toElement(node())->isDisabledFormControl();
 }
 
 void AXMenuList::didUpdateActiveOption(int optionIndex)
 {
     RefPtrWillBeRawPtr<Document> document(m_renderer->document());
     AXObjectCacheImpl* cache = toAXObjectCacheImpl(document->axObjectCache());
 
     const AccessibilityChildrenVector& childObjects = children();
     if (!childObjects.isEmpty()) {
         ASSERT(childObjects.size() == 1);
         ASSERT(childObjects[0]->isMenuListPopup());
 
         if (childObjects[0]->isMenuListPopup()) {
             if (AXMenuListPopup* popup = toAXMenuListPopup(childObjects[0].get()))
                 popup->didUpdateActiveOption(optionIndex);
         }
     }
 
     cache->postNotification(this, document.get(), AXObjectCacheImpl::AXMenuListValueChanged, true);
 }
 
 } // namespace blink