Refactor RenderQuote to not delete renderers on style change.

Refactor RenderQuote to not delete renderers on style change.

Currently the RenderQuote code will destroy all child nodes when the style
changes. This CL updates the code to re-use the existing renderer instead
of re-creating.

This fixes an issue with FirstLetterPseudoElement where we were destroying
the first-letter renderers out from under the elements feet.

BUG=424914
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184397

[dsinclair, 2014-10-24 21:04:48]

dsinclair@chromium.org changed reviewers:
+ esprehn@chromium.org, jchaffraix@chromium.org

[dsinclair, 2014-10-24 21:04:49]

PTAL.

[esprehn, 2014-10-24 21:38:26]

Where the test output or expectation?

[esprehn, 2014-10-24 21:39:19]

lgtm, please add a new test though. I think that you just fixed mixing
RenderQuote and first-letter.

[dsinclair, 2014-10-25 00:18:24]

On 2014/10/24 21:39:19, esprehn wrote:
> lgtm, please add a new test though. I think that you just fixed mixing
> RenderQuote and first-letter.

So, that's what this test is doing (I think). There is no expectation change
because I originally used uppercase in the test. Now, the transform is applied
by CSS on the quote's class. The transform is correctly getting applied to the
first letter 'b' quote so we get the original 'B' output.

This was the test I originally added in order to fix this bug (the crash
actually manifests in reverted code, but I'm fixing on ToT as it could be
separated out from the first letter pseudo element code).

[esprehn, 2014-10-25 00:20:58]

Okay, lgtm

[dsinclair, 2014-10-25 00:24:23]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-10-25 00:25:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679593004/1

[commit-bot: I haz the power, 2014-10-25 01:02:08]

Committed patchset #1 (id:1) as 184397