Issue 679583002: Fill in some missing sections in the Sky README.md

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 679583002: Fill in some missing sections in the Sky README.md (Closed)

Created:
6 years, 2 months ago by abarth-chromium

Modified:
6 years, 2 months ago

Reviewers:
ojan

CC:
ojan, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Visibility:
Public.

More Reviews

Description

Fill in some missing sections in the Sky README.md R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0acbdb3f1b274b3221061d10c444b8559ad246fe

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	sky/HACKING.md	View		1 chunk	+10 lines, -13 lines	0 comments	Download
	M	sky/README.md	View		1 chunk	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

lgtm https://codereview.chromium.org/679583002/diff/1/sky/README.md File sky/README.md (right): https://codereview.chromium.org/679583002/diff/1/sky/README.md#newcode146 sky/README.md:146: We're document Sky with a [set of technical ...

6 years, 2 months ago (2014-10-24 03:16:29 UTC) #3

abarth-chromium

6 years, 2 months ago (2014-10-24 03:32:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0acbdb3f1b274b3221061d10c444b8559ad246fe.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages