Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/service_unittest.cc

Issue 679573002: [fsp] Separate recursive and non-recursive watchers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/file_system_provider/service.h" 5 #include "chrome/browser/chromeos/file_system_provider/service.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 result->push_back(restored_file_system); 128 result->push_back(restored_file_system);
129 } 129 }
130 130
131 return result; 131 return result;
132 } 132 }
133 133
134 virtual void UpdateObservedEntryTag( 134 virtual void UpdateObservedEntryTag(
135 const ProvidedFileSystemInfo& file_system_info, 135 const ProvidedFileSystemInfo& file_system_info,
136 const ObservedEntry& observed_entry) override { 136 const ObservedEntry& observed_entry) override {
137 ASSERT_TRUE(observed_entries_.get()); 137 ASSERT_TRUE(observed_entries_.get());
138 const ObservedEntries::iterator it = 138 const ObservedEntries::iterator it = observed_entries_->find(
139 observed_entries_->find(observed_entry.entry_path); 139 ObservedEntryKey(observed_entry.entry_path, observed_entry.recursive));
140 ASSERT_NE(observed_entries_->end(), it); 140 ASSERT_NE(observed_entries_->end(), it);
141 it->second.last_tag = observed_entry.last_tag; 141 it->second.last_tag = observed_entry.last_tag;
142 } 142 }
143 143
144 ProvidedFileSystemInfo* const file_system_info() const { 144 ProvidedFileSystemInfo* const file_system_info() const {
145 return file_system_info_.get(); 145 return file_system_info_.get();
146 } 146 }
147 ObservedEntries* const observed_entries() const { 147 ObservedEntries* const observed_entries() const {
148 return observed_entries_.get(); 148 return observed_entries_.get();
149 } 149 }
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 TEST_F(FileSystemProviderServiceTest, RestoreFileSystem_OnExtensionLoad) { 395 TEST_F(FileSystemProviderServiceTest, RestoreFileSystem_OnExtensionLoad) {
396 LoggingObserver observer; 396 LoggingObserver observer;
397 service_->AddObserver(&observer); 397 service_->AddObserver(&observer);
398 398
399 // Remember a fake file system first in order to be able to restore it. 399 // Remember a fake file system first in order to be able to restore it.
400 MountOptions options(kFileSystemId, kDisplayName); 400 MountOptions options(kFileSystemId, kDisplayName);
401 options.supports_notify_tag = true; 401 options.supports_notify_tag = true;
402 ProvidedFileSystemInfo file_system_info( 402 ProvidedFileSystemInfo file_system_info(
403 kExtensionId, options, base::FilePath(FILE_PATH_LITERAL("/a/b/c"))); 403 kExtensionId, options, base::FilePath(FILE_PATH_LITERAL("/a/b/c")));
404 ObservedEntries fake_observed_entries; 404 ObservedEntries fake_observed_entries;
405 fake_observed_entries[fake_observed_entry_.entry_path] = fake_observed_entry_; 405 fake_observed_entries[ObservedEntryKey(fake_observed_entry_.entry_path,
406 fake_observed_entry_.recursive)] =
407 fake_observed_entry_;
406 registry_->RememberFileSystem(file_system_info, fake_observed_entries); 408 registry_->RememberFileSystem(file_system_info, fake_observed_entries);
407 409
408 EXPECT_EQ(0u, observer.mounts.size()); 410 EXPECT_EQ(0u, observer.mounts.size());
409 411
410 // Directly call the observer's method. 412 // Directly call the observer's method.
411 service_->OnExtensionLoaded(profile_, extension_.get()); 413 service_->OnExtensionLoaded(profile_, extension_.get());
412 414
413 ASSERT_EQ(1u, observer.mounts.size()); 415 ASSERT_EQ(1u, observer.mounts.size());
414 EXPECT_EQ(base::File::FILE_OK, observer.mounts[0].error()); 416 EXPECT_EQ(base::File::FILE_OK, observer.mounts[0].error());
415 417
(...skipping 13 matching lines...) Expand all
429 ProvidedFileSystemInterface* const file_system = 431 ProvidedFileSystemInterface* const file_system =
430 service_->GetProvidedFileSystem(kExtensionId, kFileSystemId); 432 service_->GetProvidedFileSystem(kExtensionId, kFileSystemId);
431 ASSERT_TRUE(file_system); 433 ASSERT_TRUE(file_system);
432 434
433 const ObservedEntries* const observed_entries = 435 const ObservedEntries* const observed_entries =
434 file_system->GetObservedEntries(); 436 file_system->GetObservedEntries();
435 ASSERT_TRUE(observed_entries); 437 ASSERT_TRUE(observed_entries);
436 ASSERT_EQ(1u, observed_entries->size()); 438 ASSERT_EQ(1u, observed_entries->size());
437 439
438 const ObservedEntries::const_iterator restored_observed_entry_it = 440 const ObservedEntries::const_iterator restored_observed_entry_it =
439 observed_entries->find(fake_observed_entry_.entry_path); 441 observed_entries->find(ObservedEntryKey(fake_observed_entry_.entry_path,
442 fake_observed_entry_.recursive));
440 ASSERT_NE(observed_entries->end(), restored_observed_entry_it); 443 ASSERT_NE(observed_entries->end(), restored_observed_entry_it);
441 444
442 EXPECT_EQ(fake_observed_entry_.entry_path, 445 EXPECT_EQ(fake_observed_entry_.entry_path,
443 restored_observed_entry_it->second.entry_path); 446 restored_observed_entry_it->second.entry_path);
444 EXPECT_EQ(fake_observed_entry_.recursive, 447 EXPECT_EQ(fake_observed_entry_.recursive,
445 restored_observed_entry_it->second.recursive); 448 restored_observed_entry_it->second.recursive);
446 EXPECT_EQ(fake_observed_entry_.last_tag, 449 EXPECT_EQ(fake_observed_entry_.last_tag,
447 restored_observed_entry_it->second.last_tag); 450 restored_observed_entry_it->second.last_tag);
448 451
449 service_->RemoveObserver(&observer); 452 service_->RemoveObserver(&observer);
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 EXPECT_EQ(1u, observer.unmounts.size()); 523 EXPECT_EQ(1u, observer.unmounts.size());
521 EXPECT_FALSE(registry_->file_system_info()); 524 EXPECT_FALSE(registry_->file_system_info());
522 EXPECT_FALSE(registry_->observed_entries()); 525 EXPECT_FALSE(registry_->observed_entries());
523 } 526 }
524 527
525 service_->RemoveObserver(&observer); 528 service_->RemoveObserver(&observer);
526 } 529 }
527 530
528 } // namespace file_system_provider 531 } // namespace file_system_provider
529 } // namespace chromeos 532 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service.cc ('k') | chrome/common/extensions/api/file_system_provider.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698