Issue 679543002: Add sandbox/linux and other necessary deps to pull from chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 679543002: Add sandbox/linux and other necessary deps to pull from chromium (Closed)

Created:
6 years, 1 month ago by jamesr

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Visibility:
Public.

More Reviews

Description

Add sandbox/linux and other necessary deps to pull from chromium This adds sandbox/linux/ and sandbox/sandbox_export.h along with a few other directories that are needed on chromium ToT. TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/25430fcd291f99e168bcb356b588157473f4686b

Patch Set 1 #

Patch Set 2 : add third_party/checkstyle #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	mojo/tools/roll/rev.py	View	1	6 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

Committed patchset #2 (id:20001) manually as 25430fcd291f99e168bcb356b588157473f4686b (presubmit successful).

6 years, 1 month ago (2014-10-24 01:09:06 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages