content/browser/android/content_view_core_impl.cc - Issue 679493002: [Android] Add a native pull-to-refresh overscroll effect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 679493002: [Android] Add a native pull-to-refresh overscroll effect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests! Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/browser/android/edge_effect.cc » ('j') | content/browser/android/overscroll_controller_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index d9b98790bc20c71497fc617c00304b2d371bc508..f8240a1609b8e3dea6657e74ad6dbabee42c85d7 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -748,6 +748,12 @@ float ContentViewCoreImpl::GetTopControlsLayoutHeightDip() const {

return GetTopControlsLayoutHeightPix() / dpi_scale();

}

+void ContentViewCoreImpl::SetNeedsAnimate() {

+ RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();

+ if (view)

+ view->SetNeedsAnimate();

void ContentViewCoreImpl::AttachLayer(scoped_refptr<cc::Layer> layer) {

root_layer_->InsertChild(layer, 0);

root_layer_->SetIsDrawable(false);