Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 679453002: ChannelMojo: Replace hand written messsages with mojo. (Closed)

Created:
6 years, 2 months ago by Hajime Morrita
Modified:
6 years, 1 month ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ChannelMojo: Replace hand written messsages with mojo. This change introduces client_channel.mojom to define internal messages for ChannelMojo. Hand-written HelloMessage routines are no longer needed. This is a preparation for coming fix which needs additional internal messages. TEST=ipc_mojo_unittest R=viettrungluu@chromium.org BUG=377980 Committed: https://crrev.com/f8f92dcd264f565033fef993d2f9e9b0cabd3d40 Cr-Commit-Position: refs/heads/master@{#301428}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated. #

Total comments: 17

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 2

Patch Set 6 : Landing #

Patch Set 7 : Landing (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -273 lines) Patch
M ipc/mojo/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
A + ipc/mojo/client_channel.mojom View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 3 4 4 chunks +7 lines, -5 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 2 3 4 5 5 chunks +140 lines, -28 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_readers.cc View 1 2 3 2 chunks +0 lines, -237 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
Hajime Morrita
6 years, 2 months ago (2014-10-23 21:20:46 UTC) #1
viettrungluu
https://codereview.chromium.org/679453002/diff/1/ipc/mojo/client_channel.mojom File ipc/mojo/client_channel.mojom (right): https://codereview.chromium.org/679453002/diff/1/ipc/mojo/client_channel.mojom#newcode7 ipc/mojo/client_channel.mojom:7: interface ClientChannelClient { Note that order of interface declaration ...
6 years, 2 months ago (2014-10-24 01:23:46 UTC) #2
Hajime Morrita
Thanks for the review. PTAL? https://codereview.chromium.org/679453002/diff/1/ipc/mojo/client_channel.mojom File ipc/mojo/client_channel.mojom (right): https://codereview.chromium.org/679453002/diff/1/ipc/mojo/client_channel.mojom#newcode7 ipc/mojo/client_channel.mojom:7: interface ClientChannelClient { On ...
6 years, 2 months ago (2014-10-24 17:35:11 UTC) #3
viettrungluu
https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/client_channel.mojom File ipc/mojo/client_channel.mojom (right): https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/client_channel.mojom#newcode8 ipc/mojo/client_channel.mojom:8: InitClientChannel(handle<message_pipe>? pipe, int32 peer_pid) => (int32 pid); nit: Name ...
6 years, 1 month ago (2014-10-24 20:17:01 UTC) #4
Hajime Morrita
PTAL? https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/client_channel.mojom File ipc/mojo/client_channel.mojom (right): https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/client_channel.mojom#newcode8 ipc/mojo/client_channel.mojom:8: InitClientChannel(handle<message_pipe>? pipe, int32 peer_pid) => (int32 pid); On ...
6 years, 1 month ago (2014-10-24 21:05:37 UTC) #5
Hajime Morrita
https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/ipc_channel_mojo_readers.cc File ipc/mojo/ipc_channel_mojo_readers.cc (right): https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/ipc_channel_mojo_readers.cc#newcode5 ipc/mojo/ipc_channel_mojo_readers.cc:5: #include "ipc/mojo/ipc_channel_mojo_readers.h" On 2014/10/24 20:17:01, viettrungluu wrote: > Now ...
6 years, 1 month ago (2014-10-24 21:12:07 UTC) #6
viettrungluu
https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/ipc_channel_mojo.cc File ipc/mojo/ipc_channel_mojo.cc (right): https://codereview.chromium.org/679453002/diff/20001/ipc/mojo/ipc_channel_mojo.cc#newcode87 ipc/mojo/ipc_channel_mojo.cc:87: callback.Run(GetSelfPID()); On 2014/10/24 21:05:37, morrita wrote: > On 2014/10/24 ...
6 years, 1 month ago (2014-10-24 22:48:06 UTC) #7
Hajime Morrita
PTAL? > That just gets you into trouble when you do |static_cast<base::ProcessId>()| on > Linux ...
6 years, 1 month ago (2014-10-24 22:58:20 UTC) #8
viettrungluu
lgtm w/nit https://codereview.chromium.org/679453002/diff/80001/ipc/mojo/ipc_channel_mojo.cc File ipc/mojo/ipc_channel_mojo.cc (right): https://codereview.chromium.org/679453002/diff/80001/ipc/mojo/ipc_channel_mojo.cc#newcode290 ipc/mojo/ipc_channel_mojo.cc:290: listener_->OnChannelConnected( nit: everything fits on a single ...
6 years, 1 month ago (2014-10-24 23:00:47 UTC) #9
Hajime Morrita
Thanks for the review! Landing. https://codereview.chromium.org/679453002/diff/80001/ipc/mojo/ipc_channel_mojo.cc File ipc/mojo/ipc_channel_mojo.cc (right): https://codereview.chromium.org/679453002/diff/80001/ipc/mojo/ipc_channel_mojo.cc#newcode290 ipc/mojo/ipc_channel_mojo.cc:290: listener_->OnChannelConnected( On 2014/10/24 23:00:47, ...
6 years, 1 month ago (2014-10-24 23:04:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679453002/100001
6 years, 1 month ago (2014-10-24 23:07:11 UTC) #12
commit-bot: I haz the power
Failed to apply patch for ipc/mojo/client_channel.mojom: While running git apply --index -3 -p1; error: mojo/examples/echo/echo_service.mojom: ...
6 years, 1 month ago (2014-10-25 00:47:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679453002/120001
6 years, 1 month ago (2014-10-27 18:14:17 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 1 month ago (2014-10-27 20:10:35 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:11:13 UTC) #19
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f8f92dcd264f565033fef993d2f9e9b0cabd3d40
Cr-Commit-Position: refs/heads/master@{#301428}

Powered by Google App Engine
This is Rietveld 408576698