Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 679433004: Fix non-TF targets after r24874. (Closed)

Created:
6 years, 2 months ago by paul.l...
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix non-TF targets after r24874. Fix mips64 and presumably x87. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/compiler/instruction-selector.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
paul.l...
PTAL.
6 years, 2 months ago (2014-10-24 16:13:47 UTC) #2
sigurds
On 2014/10/24 16:13:47, paul.l... wrote: > PTAL. LGTM. Sorry, I should have thought of that.
6 years, 1 month ago (2014-10-27 09:15:19 UTC) #3
akos.palfi.imgtec
I'll land this.
6 years, 1 month ago (2014-10-27 10:06:04 UTC) #4
akos.palfi.imgtec
It seems sigurds is not an owner, so I can't land. Could someone of the ...
6 years, 1 month ago (2014-10-27 10:20:10 UTC) #5
Michael Starzinger
LGTM.
6 years, 1 month ago (2014-10-27 10:26:59 UTC) #7
akos.palfi.imgtec
6 years, 1 month ago (2014-10-27 10:29:58 UTC) #8
Committed as r24897.

Powered by Google App Engine
This is Rietveld 408576698