Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 679413002: Revert of Re-add suppressions for magnifier and dropshadow GMs. (Closed)

Created:
6 years, 1 month ago by hcm
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Re-add suppressions for magnifier and dropshadow GMs. (patchset #1 id:1 of https://codereview.chromium.org/686573002/) Reason for revert: Trying to get revert of patchset potentially causing failures on image filter tests Original issue's description: > Re-add suppressions for magnifier and dropshadow GMs. > > Brian's change has invalidated the new baselines, so they'll need > to be rebaselined again once his changed has worked its way through. > > TBR=bsalomon > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fa4689d56384da5bb264a480e636fac126fb93ca TBR=bsalomon@google.com,senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ac011a5f90f273501f5ffd415c506dc1f7eae039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hcm
Created Revert of Re-add suppressions for magnifier and dropshadow GMs.
6 years, 1 month ago (2014-10-28 03:48:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679413002/1
6 years, 1 month ago (2014-10-28 03:48:53 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 03:49:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ac011a5f90f273501f5ffd415c506dc1f7eae039

Powered by Google App Engine
This is Rietveld 408576698