Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 679333005: Attempt to make skydb more user-friendly (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Attempt to make skydb more user-friendly Automatically shut-down the sky_server when quitting. Always start the skyserver at the mojo-root instead of the parent directory to the path. Log when starting a sky_server outside the mojo root. Re-use already running sky_servers when possible. R=esprehn@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/182a27658bf89ffd4de06d6b4ebb3d316f9593e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -43 lines) Patch
M sky/tools/skydb View 2 chunks +76 lines, -43 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
6 years, 1 month ago (2014-10-31 17:24:08 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-31 17:27:15 UTC) #3
eseidel
6 years, 1 month ago (2014-10-31 17:32:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
182a27658bf89ffd4de06d6b4ebb3d316f9593e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698