Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/installer/util/delete_tree_work_item_unittest.cc

Issue 6793008: Replacing base::DIR_TEMP with ScopedTempDir when appropriate. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Needed to rebase; patch didn't apply cleanly to save_package_unittest. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/create_dir_work_item_unittest.cc ('k') | chrome/installer/util/lzma_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/delete_tree_work_item_unittest.cc
diff --git a/chrome/installer/util/delete_tree_work_item_unittest.cc b/chrome/installer/util/delete_tree_work_item_unittest.cc
index 3215d57b07e4d2986facda590425cbfb005d6db8..b22ba81f4fd0159aea7bae61255f0bd3acf9055e 100644
--- a/chrome/installer/util/delete_tree_work_item_unittest.cc
+++ b/chrome/installer/util/delete_tree_work_item_unittest.cc
@@ -22,25 +22,11 @@ namespace {
class DeleteTreeWorkItemTest : public testing::Test {
protected:
virtual void SetUp() {
- // Name a subdirectory of the user temp directory.
- ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &test_dir_));
- test_dir_ = test_dir_.AppendASCII("DeleteTreeWorkItemTest");
-
- // Create a fresh, empty copy of this test directory.
- file_util::Delete(test_dir_, true);
- file_util::CreateDirectoryW(test_dir_);
-
- ASSERT_TRUE(file_util::PathExists(test_dir_));
- }
-
- virtual void TearDown() {
- // Clean up test directory
- ASSERT_TRUE(file_util::Delete(test_dir_, true));
- ASSERT_FALSE(file_util::PathExists(test_dir_));
+ ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
}
- // the path to temporary directory used to contain the test operations
- FilePath test_dir_;
+ // The temporary directory used to contain the test operations.
+ ScopedTempDir temp_dir_;
};
// Simple function to dump some text into a new file.
@@ -59,8 +45,8 @@ namespace {
// Delete a tree without key path. Everything should be deleted.
TEST_F(DeleteTreeWorkItemTest, DeleteTreeNoKeyPath) {
- // Create tree to be deleted
- FilePath dir_name_delete(test_dir_);
+ // Create tree to be deleted.
+ FilePath dir_name_delete(temp_dir_.path());
dir_name_delete = dir_name_delete.AppendASCII("to_be_delete");
file_util::CreateDirectory(dir_name_delete);
ASSERT_TRUE(file_util::PathExists(dir_name_delete));
@@ -85,7 +71,7 @@ TEST_F(DeleteTreeWorkItemTest, DeleteTreeNoKeyPath) {
CreateTextFile(file_name_delete_2.value(), text_content_1);
ASSERT_TRUE(file_util::PathExists(file_name_delete_2));
- // test Do()
+ // Test Do().
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
@@ -112,7 +98,7 @@ TEST_F(DeleteTreeWorkItemTest, DeleteTreeNoKeyPath) {
// Rollback should bring back everything
TEST_F(DeleteTreeWorkItemTest, DeleteTree) {
// Create tree to be deleted
- FilePath dir_name_delete(test_dir_);
+ FilePath dir_name_delete(temp_dir_.path());
dir_name_delete = dir_name_delete.AppendASCII("to_be_delete");
file_util::CreateDirectory(dir_name_delete);
ASSERT_TRUE(file_util::PathExists(dir_name_delete));
@@ -162,7 +148,7 @@ TEST_F(DeleteTreeWorkItemTest, DeleteTree) {
// Delete a tree with key_path in use. Everything should still be there.
TEST_F(DeleteTreeWorkItemTest, DeleteTreeInUse) {
// Create tree to be deleted
- FilePath dir_name_delete(test_dir_);
+ FilePath dir_name_delete(temp_dir_.path());
dir_name_delete = dir_name_delete.AppendASCII("to_be_delete");
file_util::CreateDirectory(dir_name_delete);
ASSERT_TRUE(file_util::PathExists(dir_name_delete));
« no previous file with comments | « chrome/installer/util/create_dir_work_item_unittest.cc ('k') | chrome/installer/util/lzma_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698