Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1878)

Unified Diff: app/sql/transaction_unittest.cc

Issue 6793008: Replacing base::DIR_TEMP with ScopedTempDir when appropriate. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Needed to rebase; patch didn't apply cleanly to save_package_unittest. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/sql/statement_unittest.cc ('k') | base/i18n/file_util_icu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/sql/transaction_unittest.cc
diff --git a/app/sql/transaction_unittest.cc b/app/sql/transaction_unittest.cc
index 9ca6bbda15910bf717fc5e232363f5c97c124d93..c8e986df110ed1fbaa993e0b454fa4b364fa74a7 100644
--- a/app/sql/transaction_unittest.cc
+++ b/app/sql/transaction_unittest.cc
@@ -1,13 +1,12 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "app/sql/connection.h"
#include "app/sql/statement.h"
#include "app/sql/transaction.h"
-#include "base/file_path.h"
#include "base/file_util.h"
-#include "base/path_service.h"
+#include "base/memory/scoped_temp_dir.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/sqlite/sqlite3.h"
@@ -16,20 +15,15 @@ class SQLTransactionTest : public testing::Test {
SQLTransactionTest() {}
void SetUp() {
- ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &path_));
- path_ = path_.AppendASCII("SQLStatementTest.db");
- file_util::Delete(path_, false);
- ASSERT_TRUE(db_.Open(path_));
+ ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+ ASSERT_TRUE(db_.Open(
+ temp_dir_.path().AppendASCII("SQLTransactionTest.db")));
ASSERT_TRUE(db().Execute("CREATE TABLE foo (a, b)"));
}
void TearDown() {
db_.Close();
-
- // If this fails something is going on with cleanup and later tests may
- // fail, so we want to identify problems right away.
- ASSERT_TRUE(file_util::Delete(path_, false));
}
sql::Connection& db() { return db_; }
@@ -42,7 +36,7 @@ class SQLTransactionTest : public testing::Test {
}
private:
- FilePath path_;
+ ScopedTempDir temp_dir_;
sql::Connection db_;
};
« no previous file with comments | « app/sql/statement_unittest.cc ('k') | base/i18n/file_util_icu_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698