Replacing base::DIR_TEMP with ScopedTempDir when appropriate.

chrome/browser/download/save_package_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/path_service.h"
+#include "base/memory/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/download/save_package.h"
 #include "chrome/browser/net/url_request_mock_http_job.h"
 #include "content/browser/renderer_host/test_render_view_host.h"
 #include "content/browser/tab_contents/test_tab_contents.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #define FPL FILE_PATH_LITERAL
@@ skipping 72 matching lines @@
   GURL GetUrlToBeSaved() {
     return save_package_success_->GetUrlToBeSaved();
   }
 
  protected:
   virtual void SetUp() {
     RenderViewHostTestHarness::SetUp();
 
     // Do the initialization in SetUp so contents() is initialized by
     // RenderViewHostTestHarness::SetUp.
-    FilePath test_dir;
-    PathService::Get(base::DIR_TEMP, &test_dir);
+    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
 
     save_package_success_ = new SavePackage(contents(),
-        test_dir.AppendASCII("testfile" HTML_EXTENSION),
-        test_dir.AppendASCII("testfile_files"));
+        temp_dir_.path().AppendASCII("testfile" HTML_EXTENSION),
+        temp_dir_.path().AppendASCII("testfile_files"));
 
     // We need to construct a path that is *almost* kMaxFilePathLength long
     long_file_name.resize(kMaxFilePathLength + long_file_name.length());
     while (long_file_name.length() < kMaxFilePathLength)
       long_file_name += long_file_name;
-    long_file_name.resize(kMaxFilePathLength - 9 - test_dir.value().length());
+    long_file_name.resize(
+        kMaxFilePathLength - 9 - temp_dir_.path().value().length());
 
     save_package_fail_ = new SavePackage(contents(),
-        test_dir.AppendASCII(long_file_name + HTML_EXTENSION),
-        test_dir.AppendASCII(long_file_name + "_files"));
+        temp_dir_.path().AppendASCII(long_file_name + HTML_EXTENSION),
+        temp_dir_.path().AppendASCII(long_file_name + "_files"));
   }
 
  private:
   // SavePackage for successfully generating file name.
   scoped_refptr<SavePackage> save_package_success_;
   // SavePackage for failed generating file name.
   scoped_refptr<SavePackage> save_package_fail_;
 
+  ScopedTempDir temp_dir_;
+
   DISALLOW_COPY_AND_ASSIGN(SavePackageTest);
 };
 
 static const struct {
   const char* disposition;
   const char* url;
   const FilePath::CharType* expected_name;
   bool need_htm_ext;
 } kGeneratedFiles[] = {
   // We mainly focus on testing duplicated names here, since retrieving file
@@ skipping 246 matching lines @@
 TEST_F(SavePackageTest, TestGetUrlToBeSavedViewSource) {
   FilePath file_name(FILE_PATH_LITERAL("a.htm"));
   GURL view_source_url = URLRequestMockHTTPJob::GetMockViewSourceUrl(
                              FilePath(kTestDir).Append(file_name));
   GURL actual_url = URLRequestMockHTTPJob::GetMockUrl(
                         FilePath(kTestDir).Append(file_name));
   NavigateAndCommit(view_source_url);
   EXPECT_EQ(actual_url, GetUrlToBeSaved());
   EXPECT_EQ(view_source_url, contents()->GetURL());
 }