Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gft_report.py

Issue 6793006: gooftool: fix EC/BIOS wpstatus in report (Closed) Base URL: ssh://gitrw.chromium.org:9222/factory_test_tools.git@master
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gft_report.py
diff --git a/gft_report.py b/gft_report.py
index 0b100be95f2eabfcc589c36d08e9744fad56a0c0..456ba89754108ad0cdfb7b9be491a4bba03ccd39 100755
--- a/gft_report.py
+++ b/gft_report.py
@@ -205,10 +205,12 @@ def CreateReport(create_params,
[(key, ', '.join(value)) for key, value in probed_components.items()])
# Firmware write protection status
- wp_status_message = (
- 'main: %s\nec: %s' %
- (gft_common.SystemOutput('flashrom -p internal:bus=lpc --wp-status'),
- gft_common.SystemOutput('flashrom -p internal:bus=spi --wp-status')))
+ ec_wp_status = gft_common.SystemOutput(
+ 'flashrom -p internal:bus=lpc --wp-status')
+ bios_wp_status = gft_common.SystemOutput(
+ 'flashrom -p internal:bus=spi --wp-status')
+
+ wp_status_message = 'main: %s\nec: %s' % (bios_wp_status, ec_wp_status)
report['wp_status'] = wp_status_message.splitlines()
# TODO(hungte) we may also add these data in future:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698