Issue 6793006: gooftool: fix EC/BIOS wpstatus in report

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6793006: gooftool: fix EC/BIOS wpstatus in report (Closed)

Created:
9 years, 8 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Louis

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/factory_test_tools.git@master

Visibility:
Public.

Description

gooftool: fix EC/BIOS wpstatus in report In http://codereview.chromium.org/6778007 the execution order of write-protection status probing is changed to prevent EC issue, however the text message is not changed. This CL corrects the output message, and isolate the execution commands so that we may disable checking of EC on ARM platforms in future. BUG=chrome-os-partner:854 TEST=gooftool --finalize --db_path DBPATH --upload_method none flashrom -V | grep Found # the output is SPI(BIOS), not LPC(EC). reboot # success on Z* Change-Id: Iebe80a84a36349d7dcac006fb6cbcba3932ce069 R=yjlou@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4e23867

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	gft_report.py	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages