 Chromium Code Reviews
 Chromium Code Reviews Issue 679273004:
  Set element value to its default value  on reset  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 679273004:
  Set element value to its default value  on reset  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/html/HTMLInputElement.cpp | 
| diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp | 
| index 1d97194ccb36804bb4c08e50ad3ffafbc6f647d7..e3914eceabadc1455095ff39033350eead69aef3 100644 | 
| --- a/Source/core/html/HTMLInputElement.cpp | 
| +++ b/Source/core/html/HTMLInputElement.cpp | 
| @@ -839,7 +839,7 @@ String HTMLInputElement::resultForDialogSubmit() | 
| void HTMLInputElement::resetImpl() | 
| { | 
| if (m_inputType->storesValueSeparateFromAttribute()) { | 
| - setValue(String()); | 
| + setValue(String(), DispatchNoEvent); | 
| 
tkent
2014/11/10 01:54:39
This change is unnecessary.
 
Habib Virji
2014/11/13 15:00:55
Acknowledged.
 | 
| setNeedsValidityCheck(); | 
| } | 
| @@ -1027,7 +1027,7 @@ void HTMLInputElement::setValue(const String& value, TextFieldEventBehavior even | 
| m_inputType->setValue(sanitizedValue, valueChanged, eventBehavior); | 
| if (valueChanged && eventBehavior == DispatchNoEvent) | 
| - setTextAsOfLastFormControlChangeEvent(sanitizedValue); | 
| + setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? defaultValue() : sanitizedValue); | 
| if (!valueChanged) | 
| return; |