Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 679273004: Set element value to its default value on reset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/forms/text/text-reset-click-delete-text-change-event-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index d0704564663d4357c2add46e8a78209cd188920e..b3af7171966c89acfbec0c72d4ef088d222e51c7 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -839,7 +839,7 @@ String HTMLInputElement::resultForDialogSubmit()
void HTMLInputElement::resetImpl()
{
if (m_inputType->storesValueSeparateFromAttribute()) {
- setValue(String());
+ setValue(defaultValue());
tkent 2014/10/29 00:28:29 This is a wrong fix. Setting a null string to the
setNeedsValidityCheck();
}
« no previous file with comments | « LayoutTests/fast/forms/text/text-reset-click-delete-text-change-event-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698