Set element value to its default value on reset

Source/core/html/forms/TextFieldInputType.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 171 matching lines @@
         input->dispatchFormControlInputEvent();
         input->dispatchFormControlChangeEvent();
         break;
     }
 
     case DispatchNoEvent:
         break;
     }
 
     if (!input->focused())
-        input->setTextAsOfLastFormControlChangeEvent(sanitizedValue);
+        input->setTextAsOfLastFormControlChangeEvent(sanitizedValue.isNull() ? visibleValue() : sanitizedValue);

[tkent, 2014/11/10 01:54:39]

Why is it visibleValue(), instead of defaultValue()?

[Habib Virji, 2014/11/13 15:00:56]

As defaultValue() and sanitizedValue both hold null string.   

[tkent, 2014/11/14 00:23:56]

Using visibleValue() is semantically incorrect.  If you need a non-null empty
string, use emptyString() like HTMLTextFormControlElement::insertedInto does.

[Habib Virji, 2014/11/24 11:05:32]

Done.

 }
 
 void TextFieldInputType::handleKeydownEvent(KeyboardEvent* event)
 {
     if (!element().focused())
         return;
     if (Chrome* chrome = this->chrome()) {
         chrome->client().handleKeyboardEventOnTextField(element(), *event);
         return;
     }
@@ skipping 346 matching lines @@
     return shouldSpinButtonRespondToMouseEvents() && element().focused();
 }
 
 void TextFieldInputType::spinButtonDidReleaseMouseCapture(SpinButtonElement::EventDispatch eventDispatch)
 {
     if (eventDispatch == SpinButtonElement::EventDispatchAllowed)
         element().dispatchFormControlChangeEvent();
 }
 
 } // namespace blink