chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc - Issue 679273002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 679273002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

index fa7781220781011ad395d60ca84bf78cc5d1a101..b55232f5c471c3e4eca9221b84e38d46230d832d 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

@@ -71,9 +71,9 @@ class PhishingDOMFeatureExtractorTest : public InProcessBrowserTest {

protected:

PhishingDOMFeatureExtractorTest() : weak_factory_(this) {}

- virtual ~PhishingDOMFeatureExtractorTest() {}

+ ~PhishingDOMFeatureExtractorTest() override {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

command_line->AppendSwitch(switches::kSingleProcess);

#if defined(OS_WIN)

// Don't want to try to create a GPU process.

@@ -81,7 +81,7 @@ class PhishingDOMFeatureExtractorTest : public InProcessBrowserTest {

#endif

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

extractor_.reset(new PhishingDOMFeatureExtractor(

content::RenderView::FromRoutingID(kRenderViewRoutingId), &clock_));