chrome/renderer/printing/print_web_view_helper_browsertest.cc - Issue 679273002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_browsertest.cc

Issue 679273002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/printing/print_web_view_helper_browsertest.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_browsertest.cc b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

index 5e45e767fd591590ad45bbf79e53fb4f80df6da8..38cfc60c66b0145b78a22ce09a7df750e6956c89 100644

--- a/chrome/renderer/printing/print_web_view_helper_browsertest.cc

+++ b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

@@ -128,7 +128,7 @@ class DidPreviewPageListener : public IPC::Listener {

class PrintWebViewHelperTestBase : public ChromeRenderViewTest {

public:

PrintWebViewHelperTestBase() {}

- virtual ~PrintWebViewHelperTestBase() {}

+ ~PrintWebViewHelperTestBase() override {}

protected:

void PrintWithJavaScript() {

@@ -226,11 +226,9 @@ class PrintWebViewHelperTestBase : public ChromeRenderViewTest {

class PrintWebViewHelperTest : public PrintWebViewHelperTestBase {

public:

PrintWebViewHelperTest() {}

- virtual ~PrintWebViewHelperTest() {}

+ ~PrintWebViewHelperTest() override {}

- virtual void SetUp() override {

- ChromeRenderViewTest::SetUp();

- }

+ void SetUp() override { ChromeRenderViewTest::SetUp(); }

protected:

DISALLOW_COPY_AND_ASSIGN(PrintWebViewHelperTest);

@@ -470,7 +468,7 @@ TEST_F(PrintWebViewHelperTest, PrintLayoutTest) {

class PrintWebViewHelperPreviewTest : public PrintWebViewHelperTestBase {

public:

PrintWebViewHelperPreviewTest() {}

- virtual ~PrintWebViewHelperPreviewTest() {}

+ ~PrintWebViewHelperPreviewTest() override {}

protected:

void VerifyPrintPreviewCancelled(bool did_cancel) {