chrome/common/multi_process_lock_linux.cc - Issue 679273002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/multi_process_lock_linux.cc

Issue 679273002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/local_discovery/service_discovery_client_unittest.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/multi_process_lock_linux.cc

diff --git a/chrome/common/multi_process_lock_linux.cc b/chrome/common/multi_process_lock_linux.cc

index f00599f494d0c19861555bdb6d00b865ddd30424..49ec99a896f1ff30fb0d939ee3cfe7f65b9b41a8 100644

--- a/chrome/common/multi_process_lock_linux.cc

+++ b/chrome/common/multi_process_lock_linux.cc

@@ -18,13 +18,13 @@ class MultiProcessLockLinux : public MultiProcessLock {

explicit MultiProcessLockLinux(const std::string& name)

: name_(name), fd_(-1) { }

- virtual ~MultiProcessLockLinux() {

+ ~MultiProcessLockLinux() override {

if (fd_ != -1) {

Unlock();

}

- virtual bool TryLock() override {

+ bool TryLock() override {

struct sockaddr_un address;

// +1 for terminator, +1 for 0 in position 0 that makes it an

@@ -85,7 +85,7 @@ class MultiProcessLockLinux : public MultiProcessLock {

}

- virtual void Unlock() override {

+ void Unlock() override {

if (fd_ == -1) {

DLOG(ERROR) << "Over-unlocked MultiProcessLock - " << name_;

return;