Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: chrome/utility/extensions/unpacker_unittest.cc

Issue 679273002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_util.h" 5 #include "base/files/file_util.h"
6 #include "base/files/scoped_temp_dir.h" 6 #include "base/files/scoped_temp_dir.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/common/chrome_paths.h" 11 #include "chrome/common/chrome_paths.h"
12 #include "chrome/utility/extensions/unpacker.h" 12 #include "chrome/utility/extensions/unpacker.h"
13 #include "extensions/common/constants.h" 13 #include "extensions/common/constants.h"
14 #include "extensions/common/extension.h" 14 #include "extensions/common/extension.h"
15 #include "extensions/common/manifest_constants.h" 15 #include "extensions/common/manifest_constants.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 #include "third_party/skia/include/core/SkBitmap.h" 17 #include "third_party/skia/include/core/SkBitmap.h"
18 18
19 using base::ASCIIToUTF16; 19 using base::ASCIIToUTF16;
20 20
21 namespace extensions { 21 namespace extensions {
22 22
23 namespace errors = manifest_errors; 23 namespace errors = manifest_errors;
24 namespace keys = manifest_keys; 24 namespace keys = manifest_keys;
25 25
26 class UnpackerTest : public testing::Test { 26 class UnpackerTest : public testing::Test {
27 public: 27 public:
28 virtual ~UnpackerTest() { 28 ~UnpackerTest() override {
29 LOG(WARNING) << "Deleting temp dir: " 29 LOG(WARNING) << "Deleting temp dir: "
30 << temp_dir_.path().LossyDisplayName(); 30 << temp_dir_.path().LossyDisplayName();
31 LOG(WARNING) << temp_dir_.Delete(); 31 LOG(WARNING) << temp_dir_.Delete();
32 } 32 }
33 33
34 void SetupUnpacker(const std::string& crx_name) { 34 void SetupUnpacker(const std::string& crx_name) {
35 base::FilePath original_path; 35 base::FilePath original_path;
36 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &original_path)); 36 ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &original_path));
37 original_path = original_path.AppendASCII("extensions") 37 original_path = original_path.AppendASCII("extensions")
38 .AppendASCII("unpacker") 38 .AppendASCII("unpacker")
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 SetupUnpacker("bad_image.crx"); 169 SetupUnpacker("bad_image.crx");
170 EXPECT_FALSE(unpacker_->Run()); 170 EXPECT_FALSE(unpacker_->Run());
171 EXPECT_TRUE(StartsWith(unpacker_->error_message(), 171 EXPECT_TRUE(StartsWith(unpacker_->error_message(),
172 ASCIIToUTF16(kExpected), 172 ASCIIToUTF16(kExpected),
173 false)) << "Expected prefix: \"" << kExpected 173 false)) << "Expected prefix: \"" << kExpected
174 << "\", actual error: \"" << unpacker_->error_message() 174 << "\", actual error: \"" << unpacker_->error_message()
175 << "\""; 175 << "\"";
176 } 176 }
177 177
178 } // namespace extensions 178 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/test/remoting/remote_desktop_browsertest.h ('k') | chrome/utility/image_writer/image_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698