Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 679273002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string.h> 5 #include <string.h>
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/test/histogram_tester.h" 9 #include "base/test/histogram_tester.h"
10 #include "chrome/test/base/chrome_render_view_test.h" 10 #include "chrome/test/base/chrome_render_view_test.h"
(...skipping 13 matching lines...) Expand all
24 using blink::WebInputElement; 24 using blink::WebInputElement;
25 using blink::WebNode; 25 using blink::WebNode;
26 using blink::WebString; 26 using blink::WebString;
27 27
28 namespace autofill { 28 namespace autofill {
29 29
30 class PasswordGenerationAgentTest : public ChromeRenderViewTest { 30 class PasswordGenerationAgentTest : public ChromeRenderViewTest {
31 public: 31 public:
32 PasswordGenerationAgentTest() {} 32 PasswordGenerationAgentTest() {}
33 33
34 virtual void TearDown() { 34 void TearDown() override {
35 LoadHTML(""); 35 LoadHTML("");
36 ChromeRenderViewTest::TearDown(); 36 ChromeRenderViewTest::TearDown();
37 } 37 }
38 38
39 void SetNotBlacklistedMessage(const char* form_str) { 39 void SetNotBlacklistedMessage(const char* form_str) {
40 autofill::PasswordForm form; 40 autofill::PasswordForm form;
41 form.origin = 41 form.origin =
42 GURL(base::StringPrintf("data:text/html;charset=utf-8,%s", form_str)); 42 GURL(base::StringPrintf("data:text/html;charset=utf-8,%s", form_str));
43 AutofillMsg_FormNotBlacklisted msg(0, form); 43 AutofillMsg_FormNotBlacklisted msg(0, form);
44 password_generation_->OnMessageReceived(msg); 44 password_generation_->OnMessageReceived(msg);
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 "document.body.appendChild(form);"); 379 "document.body.appendChild(form);");
380 ProcessPendingMessages(); 380 ProcessPendingMessages();
381 // TODO(gcasto): I'm slighty worried about flakes in this test where 381 // TODO(gcasto): I'm slighty worried about flakes in this test where
382 // didAssociateFormControls() isn't called. If this turns out to be a problem 382 // didAssociateFormControls() isn't called. If this turns out to be a problem
383 // adding a call to OnDynamicFormsSeen(GetMainFrame()) will fix it, though 383 // adding a call to OnDynamicFormsSeen(GetMainFrame()) will fix it, though
384 // it will weaken the test. 384 // it will weaken the test.
385 ExpectPasswordGenerationAvailable("first_password", true); 385 ExpectPasswordGenerationAvailable("first_password", true);
386 } 386 }
387 387
388 } // namespace autofill 388 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698