content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc - Issue 679243002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc

Issue 679243002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/p2p/socket_host_udp_unittest.cc ('k') | content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc

diff --git a/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc

index 72b6e2dc991563561a82ebe81f195594e54dd574..ccc9c610d21b9e91b092f1ba7780f37f24847819 100644

--- a/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc

+++ b/content/browser/renderer_host/pepper/pepper_file_system_browser_host_unittest.cc

@@ -19,9 +19,9 @@ class PepperFileSystemBrowserHostTest : public testing::Test,

public BrowserPpapiHostTest {

public:

PepperFileSystemBrowserHostTest() {}

- virtual ~PepperFileSystemBrowserHostTest() {}

+ ~PepperFileSystemBrowserHostTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

PP_Instance pp_instance = 12345;

PP_Resource pp_resource = 67890;

host_.reset(new PepperFileSystemBrowserHost(GetBrowserPpapiHost(),

@@ -30,7 +30,7 @@ class PepperFileSystemBrowserHostTest : public testing::Test,

PP_FILESYSTEMTYPE_ISOLATED));

}

- virtual void TearDown() override { host_.reset(); }

+ void TearDown() override { host_.reset(); }

protected:

std::string GeneratePluginId(const std::string& mime_type) {