content/browser/renderer_host/render_widget_host_view_android.cc - Issue 679223002: Plumb composition character bounds from C++ to Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 679223002: Plumb composition character bounds from C++ to Java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment. Add TODO. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 32d0c022837e4fb27307ab3f99d7952f32369550..30ce38aad48c5bad6a9e12ac55b0982c1a6c93ab 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -763,7 +763,7 @@ void RenderWidgetHostViewAndroid::ImeCancelComposition() {

void RenderWidgetHostViewAndroid::ImeCompositionRangeChanged(

const gfx::Range& range,

const std::vector<gfx::Rect>& character_bounds) {

- // TODO(yukawa): Implement this.

+ ime_adapter_android_.SetCharacterBounds(character_bounds);

}

void RenderWidgetHostViewAndroid::FocusedNodeChanged(bool is_editable_node) {