Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 679143002: make Handle a synonym of Local (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

make Handle a synonym of Local R=svenpanne@chromium.org BUG= Committed: https://crrev.com/202a97c88eb6807915135a1e6be9aa921cd8efac Cr-Commit-Position: refs/heads/master@{#27951}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : victory!... assuming android doesn't do anything stupid #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -120 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 14 chunks +27 lines, -119 lines 0 comments Download
M src/checks.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcarney
ptal - the bots seem to be behind, using gcc 4.6 - i could add ...
6 years, 1 month ago (2014-10-27 15:34:04 UTC) #2
Sven Panne
LGTM, but we need to update the bots first. :-/ https://codereview.chromium.org/679143002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/679143002/diff/1/include/v8.h#newcode208 ...
6 years, 1 month ago (2014-10-29 07:15:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679143002/140001
5 years, 8 months ago (2015-04-21 07:52:45 UTC) #6
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 8 months ago (2015-04-21 08:16:18 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 08:16:31 UTC) #8
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/202a97c88eb6807915135a1e6be9aa921cd8efac
Cr-Commit-Position: refs/heads/master@{#27951}

Powered by Google App Engine
This is Rietveld 408576698