Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 679113002: Replacing v8::Handle with v8::Local in src/net (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

v8::Handle<T> is just an alias of v8::Local<T> so, replacing v8::Handle with v8::Local in src/net BUG=424445 Committed: https://crrev.com/93bbc2b69c93e8820b640284f7b1257ad8d36e49 Cr-Commit-Position: refs/heads/master@{#301395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/proxy/proxy_resolver_v8.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-10-27 14:10:30 UTC) #2
Ryan Sleevi
Please pay attention to the descriptions. You referenced src/mojo, but I edited it to src/net.
6 years, 1 month ago (2014-10-27 17:00:07 UTC) #3
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-27 17:00:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/679113002/1
6 years, 1 month ago (2014-10-27 17:01:39 UTC) #6
anujsharma
On 2014/10/27 17:00:13, Ryan Sleevi wrote: > lgtm Thanks Ryan for lgtm and also correcting ...
6 years, 1 month ago (2014-10-27 17:20:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 18:00:03 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:00:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93bbc2b69c93e8820b640284f7b1257ad8d36e49
Cr-Commit-Position: refs/heads/master@{#301395}

Powered by Google App Engine
This is Rietveld 408576698