Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: net/base/net_log_logger_unittest.cc

Issue 679103004: Add function to get network stack state from a URLRequestContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_log_logger.cc ('k') | net/base/net_log_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log_logger_unittest.cc
diff --git a/net/base/net_log_logger_unittest.cc b/net/base/net_log_logger_unittest.cc
index 2f63b8d75a5f7caf8307e35e5bd0e27bc9e0a0ee..cedd27375c0829e18b46aa72664af2934d8d5b14 100644
--- a/net/base/net_log_logger_unittest.cc
+++ b/net/base/net_log_logger_unittest.cc
@@ -10,6 +10,7 @@
#include "base/json/json_reader.h"
#include "base/values.h"
#include "net/base/net_log.h"
+#include "net/base/net_log_util.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
@@ -32,7 +33,7 @@ TEST_F(NetLogLoggerTest, GeneratesValidJSONForNoEvents) {
// Create and destroy a logger.
FILE* file = base::OpenFile(log_path_, "w");
ASSERT_TRUE(file);
- scoped_ptr<base::Value> constants(NetLogLogger::GetConstants());
+ scoped_ptr<base::Value> constants(GetNetConstants());
scoped_ptr<NetLogLogger> logger(new NetLogLogger(file, *constants));
logger.reset();
@@ -54,7 +55,7 @@ TEST_F(NetLogLoggerTest, GeneratesValidJSONForNoEvents) {
TEST_F(NetLogLoggerTest, LogLevel) {
FILE* file = base::OpenFile(log_path_, "w");
ASSERT_TRUE(file);
- scoped_ptr<base::Value> constants(NetLogLogger::GetConstants());
+ scoped_ptr<base::Value> constants(GetNetConstants());
NetLogLogger logger(file, *constants);
NetLog net_log;
@@ -73,7 +74,7 @@ TEST_F(NetLogLoggerTest, LogLevel) {
TEST_F(NetLogLoggerTest, GeneratesValidJSONWithOneEvent) {
FILE* file = base::OpenFile(log_path_, "w");
ASSERT_TRUE(file);
- scoped_ptr<base::Value> constants(NetLogLogger::GetConstants());
+ scoped_ptr<base::Value> constants(GetNetConstants());
scoped_ptr<NetLogLogger> logger(new NetLogLogger(file, *constants));
const int kDummyId = 1;
@@ -104,7 +105,7 @@ TEST_F(NetLogLoggerTest, GeneratesValidJSONWithOneEvent) {
TEST_F(NetLogLoggerTest, GeneratesValidJSONWithMultipleEvents) {
FILE* file = base::OpenFile(log_path_, "w");
ASSERT_TRUE(file);
- scoped_ptr<base::Value> constants(NetLogLogger::GetConstants());
+ scoped_ptr<base::Value> constants(GetNetConstants());
scoped_ptr<NetLogLogger> logger(new NetLogLogger(file, *constants));
const int kDummyId = 1;
« no previous file with comments | « net/base/net_log_logger.cc ('k') | net/base/net_log_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698