Add function to get network stack state from a URLRequestContext.

Add function to get network stack state from a URLRequestContext.

This is aimed at adding non-NetLog information that appears in
net-internals to log dumps created directly by NetLogLogger.

BUG=426918
Committed: https://crrev.com/545029b860399fedfd9f28a4c3d0dab5c635c8dc
Cr-Commit-Position: refs/heads/master@{#301859}

[mmenke, 2014-10-28 14:56:48]

Patchset #4 (id:60001) has been deleted

[mmenke, 2014-10-28 16:21:41]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2014-10-28 16:21:42]

I want to follow this up with a CL that moves the code to create bogus events
for in-progress requests to the new file.  Then I'll make another CL which hooks
up both the new methods NetLogLogger, and updates the interface a little, so
only have to go through all current consumers in one CL.

Only planning to hook this stuff up to Cronet for now (Want to add it to
net-export, but it has threading concerns which I need to work out. 
--log-net-log=blah is weird - log lasts longer than the network stack does, so
no pending requests at log start, and there's no context with constants at
destruction time, either).

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.cc
File net/base/net_log_util.cc (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.c...
net/base/net_log_util.cc:147: }
This method is unchanged, except the addition of the above dictionary.

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.c...
net/base/net_log_util.cc:375: context->http_transaction_factory()->GetSession();
Note that I changed this code to not check for NULL session - the network stack
doesn't really work without one, anyways, unless you're using a mock transaction
factory.

Otherwise, these should basically be the same as the corresponding old methods
in net_internals_ui.cc.

[eroman, 2014-10-28 21:59:41]

lgtm

https://codereview.chromium.org/679103004/diff/100001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/679103004/diff/100001/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:438: void
SendNetInfo(int info_sources);
Please add documentation. In particular, not clear what "net info" means, or
"sources"

https://codereview.chromium.org/679103004/diff/100001/net/base/net_info_sourc...
File net/base/net_info_source_list.h (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_info_sourc...
net/base/net_info_source_list.h:16: NET_INFO_SOURCE(SPDY_ALT_PROTO_MAPPING,
"spdyAlternateProtocolMappings", 1 << 7)
nit: MAPPING --> MAPPINGS?

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.h
File net/base/net_log_util.h (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.h...
net/base/net_log_util.h:32: NET_EXPORT scoped_ptr<base::DictionaryValue>
GetNetInfo(
Documentation: Please give more details on the type of information this
contains, and what "info_sources" values can take.

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util_u...
File net/base/net_log_util_unittest.cc (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util_u...
net/base/net_log_util_unittest.cc:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
On a side note: I think we are at the point where net_logging could get its own
top level directory.

Something like:

net/logging

[mmenke, 2014-10-29 15:44:56]

Thanks for the feedback!  Absolutely correct that it needed documentation.

https://codereview.chromium.org/679103004/diff/100001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/679103004/diff/100001/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:438: void
SendNetInfo(int info_sources);
On 2014/10/28 21:59:41, eroman wrote:
> Please add documentation. In particular, not clear what "net info" means, or
> "sources"

Done.

https://codereview.chromium.org/679103004/diff/100001/net/base/net_info_sourc...
File net/base/net_info_source_list.h (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_info_sourc...
net/base/net_info_source_list.h:16: NET_INFO_SOURCE(SPDY_ALT_PROTO_MAPPING,
"spdyAlternateProtocolMappings", 1 << 7)
On 2014/10/28 21:59:41, eroman wrote:
> nit: MAPPING --> MAPPINGS?

Done, tou're right, mistake on my part...but that makes it 81 characters!  The
horror!

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.h
File net/base/net_log_util.h (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util.h...
net/base/net_log_util.h:32: NET_EXPORT scoped_ptr<base::DictionaryValue>
GetNetInfo(
On 2014/10/28 21:59:41, eroman wrote:
> Documentation: Please give more details on the type of information this
> contains, and what "info_sources" values can take.

Done.  I deliberately haven't gone into much detail about the type of
information it contains, since it would ended up basically being a list of
NetInfoSources, or summary of that list.

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util_u...
File net/base/net_log_util_unittest.cc (right):

https://codereview.chromium.org/679103004/diff/100001/net/base/net_log_util_u...
net/base/net_log_util_unittest.cc:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
On 2014/10/28 21:59:41, eroman wrote:
> On a side note: I think we are at the point where net_logging could get its
own
> top level directory.
> 
> Something like:
> 
> net/logging

Makes sense.

Such a CL would also be a good time to move BoundNetLog into its own file.  I'd
really like to make it not include NetLog in its header file, since including
NetLog everywhere includes a bunch extra files everywhere that depends on the
net stack.  Of course, to do that, we'd need to move NetLog enums outside of
NetLog as well, which would get pretty ugly.

[mmenke, 2014-10-29 15:45:08]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-10-29 15:46:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/679103004/120001

[commit-bot: I haz the power, 2014-10-29 16:45:33]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2014-10-29 16:46:22]

Patchset 6 (id:??) landed as
https://crrev.com/545029b860399fedfd9f28a4c3d0dab5c635c8dc
Cr-Commit-Position: refs/heads/master@{#301859}