Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 678973003: Removed unused ScreenObserver::OnSetUsernamePassword() method. (Closed)

Created:
6 years, 1 month ago by ygorshenin1
Modified:
6 years, 1 month ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed unused ScreenObserver::OnSetUsernamePassword() method. BUG=405876 TEST=none Committed: https://crrev.com/a47cef1eee6beea7d45ee5baffb7fd0a83ec370c Cr-Commit-Position: refs/heads/master@{#301353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/browser/chromeos/login/screens/device_disabled_screen_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screens/screen_observer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ygorshenin1
6 years, 1 month ago (2014-10-27 11:56:50 UTC) #2
Dmitry Polukhin
lgtm
6 years, 1 month ago (2014-10-27 12:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678973003/1
6 years, 1 month ago (2014-10-27 12:29:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 13:12:30 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 13:13:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a47cef1eee6beea7d45ee5baffb7fd0a83ec370c
Cr-Commit-Position: refs/heads/master@{#301353}

Powered by Google App Engine
This is Rietveld 408576698