Allow zooming error pages.

content/public/browser/host_zoom_map.h

Index: content/public/browser/host_zoom_map.h
diff --git a/content/public/browser/host_zoom_map.h b/content/public/browser/host_zoom_map.h
index 1632690fa44bd89312bca3678bdf23664b2851ab..3c21fe6f2f8e291b06c47f4f59a3b29e43d676a4 100644
--- a/content/public/browser/host_zoom_map.h
+++ b/content/public/browser/host_zoom_map.h
@@ -13,9 +13,11 @@
 #include "base/callback.h"
 #include "base/callback_list.h"
 #include "content/common/content_export.h"
+#include "url/gurl.h"
 
 namespace content {
 
+class NavigationEntry;
 class BrowserContext;
 class ResourceContext;
 class WebContents;
@@ -52,6 +54,8 @@ class HostZoomMap {
 
   typedef std::vector<ZoomLevelChange> ZoomLevelVector;
 
+  CONTENT_EXPORT static GURL GetURLFromEntry(const NavigationEntry*);

[Charlie Reis, 2014/10/28 16:36:22]

nit: Always name parameters.

Also add a comment hinting at why this is needed, rather than just using
NavigationEntry::GetURL.

[wjmaclean, 2014/10/28 17:37:04]

Done.

+
   CONTENT_EXPORT static HostZoomMap* GetDefaultForBrowserContext(
       BrowserContext* browser_context);
 
@@ -64,6 +68,11 @@ class HostZoomMap {
   CONTENT_EXPORT static void SetZoomLevel(const WebContents* web_contents,
                                           double level);
 
+  // Send an IPC to refresh any displayed error page's zoom levels. Needs to
+  // be called since error pages don't get loaded via the normal channel.
+  CONTENT_EXPORT static void SendErrorPageZoomLevelRefresh(

[Charlie Reis, 2014/10/28 16:36:22]

This doesn't appear to be called outside of content/, so it should be in the
impl file rather than the public interface.

From http://www.chromium.org/developers/content-module/content-api:
"only expose methods in the public API that embedders need. If a method is only
used by other code in content, it belongs in foo_impl.h and not foo.h."

[wjmaclean, 2014/10/28 17:37:04]

With the moving of the code out of NavigationControllerImpl, this is now called
outside content/.

+      const WebContents* web_contents);
+
   // Copy the zoom levels from the given map. Can only be called on the UI
   // thread.
   virtual void CopyFrom(HostZoomMap* copy) = 0;