Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: src/gpu/gl/builders/GrGLVertexShaderBuilder.h

Issue 678953002: Default geometry processor (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: feedback incorporated Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/gl/builders/GrGLVertexShaderBuilder.h
diff --git a/src/gpu/gl/builders/GrGLVertexShaderBuilder.h b/src/gpu/gl/builders/GrGLVertexShaderBuilder.h
index 2f14bd77022e7aa0bd66a4099e951a743d3d56ca..e895a9d4afa39a025b0fb98d93ab2a24d9bdfeea 100644
--- a/src/gpu/gl/builders/GrGLVertexShaderBuilder.h
+++ b/src/gpu/gl/builders/GrGLVertexShaderBuilder.h
@@ -16,6 +16,8 @@ class GrGLVertexBuilder : public GrGLShaderBuilder {
public:
GrGLVertexBuilder(GrGLProgramBuilder* program);
+ void transformPositionToDeviceSpace(const char* pos3);
+
/**
* Are explicit local coordinates provided as input to the vertex shader.
*/
@@ -40,12 +42,12 @@ private:
/*
* private helpers for compilation by GrGLProgramBuilder
*/
+ //TODO GP itself should setup the uniform view matrix
+ void setupUniformViewMatrix();
void setupLocalCoords();
- void transformGLToSkiaCoords();
void setupBuiltinVertexAttribute(const char* inName, GrGLSLExpr1* out);
void setupBuiltinVertexAttribute(const char* inName, GrGLSLExpr4* out);
void emitAttributes(const GrGeometryProcessor& gp);
- void transformSkiaToGLCoords();
void bindVertexAttributes(GrGLuint programID);
bool compileAndAttachShaders(GrGLuint programId, SkTDArray<GrGLuint>* shaderIds) const;
@@ -61,6 +63,7 @@ private:
GrGLShaderVar* fPositionVar;
GrGLShaderVar* fLocalCoordsVar;
+ const char* fRtAdjustName;
int fEffectAttribOffset;
friend class GrGLProgramBuilder;

Powered by Google App Engine
This is Rietveld 408576698