Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 678883002: Revert of Enable a11y audit for chrome://settings (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Dan Beam, hcarmona
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable a11y audit for chrome://settings (patchset #2 id:20001 of https://codereview.chromium.org/646853004/) Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1) started consistently failing OptionsWebUIExtendedTest.CloseOverlay in the build in which this CL landed. This touches WebUI, and is implicated in many of the stack traces. Reverting to try to green the bot. Original issue's description: > Enable a11y audit for chrome://settings > > Enabled the tests and fixed failure. Failure was due to transition obscuring elements in the UI. > > BUG=311866 > > Committed: https://crrev.com/34a84c6d1269332cc3ae2b8a50af489230c885de > Cr-Commit-Position: refs/heads/master@{#301266} TBR=dbeam@chromium.org,hcarmona@chromium.org NOTREECHECKS=true NOTRY=true BUG=311866 Committed: https://crrev.com/88ce5f888bd8707ec61cf737e78b96a0675d696b Cr-Commit-Position: refs/heads/master@{#301289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M chrome/browser/ui/webui/options/options_browsertest.js View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Enable a11y audit for chrome://settings
6 years, 1 month ago (2014-10-25 18:19:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678883002/1
6 years, 1 month ago (2014-10-25 18:20:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-25 18:20:56 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 18:21:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ce5f888bd8707ec61cf737e78b96a0675d696b
Cr-Commit-Position: refs/heads/master@{#301289}

Powered by Google App Engine
This is Rietveld 408576698