Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 678843004: Use shared function info for eval cache key. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use shared function info for eval cache key. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -85 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compilation-cache.h View 3 chunks +7 lines, -10 lines 0 comments Download
M src/compilation-cache.cc View 6 chunks +15 lines, -18 lines 0 comments Download
M src/compiler.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M src/runtime/runtime-debug.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-eval-cache.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 1 month ago (2014-10-27 16:36:11 UTC) #1
Toon Verwaest
lgtm, thanks for fixing this.
6 years, 1 month ago (2014-10-28 09:36:34 UTC) #2
Toon Verwaest
lgtm, thanks for fixing this.
6 years, 1 month ago (2014-10-28 09:36:35 UTC) #3
Yang
6 years, 1 month ago (2014-10-28 10:00:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698