Issue 678843003: Revert of Clip mask manager sets stencil on draw type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 678843003: Revert of Clip mask manager sets stencil on draw type (Closed)

Created:
6 years, 1 month ago by joshualitt

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Clip mask manager sets stencil on draw type (patchset #3 id:40001 of https://codereview.chromium.org/676983003/) Reason for revert: seems to cause a gm issue on windows. Original issue's description: > Clip mask manager sets stencil on draw type > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7afb5aa201e4b59397cbd8480e121d7501a227e7 TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3a0cfeb96185934c0a36f1313f21b96c57ca6341

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -75 lines)			Patch
M	src/gpu/GrClipMaskManager.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	13 chunks	+19 lines, -17 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	3 chunks	+16 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	5 chunks	+6 lines, -12 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Clip mask manager sets stencil on draw type

6 years, 1 month ago (2014-10-27 14:37:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678843003/1

6 years, 1 month ago (2014-10-27 14:37:53 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-27 14:38:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 3a0cfeb96185934c0a36f1313f21b96c57ca6341