chrome/browser/ui/views/bookmarks/bookmark_context_menu.h - Issue 678803003: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

Issue 678803003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

index dc0b42444ff298eaf0c8df7e756ae0e6d3525e87..4631eaadadfd1e1c35ebc9533908f64aa2f4298c 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu.h

@@ -42,7 +42,7 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate,

const BookmarkNode* parent,

const std::vector<const BookmarkNode*>& selection,

bool close_on_remove);

- virtual ~BookmarkContextMenu();

+ ~BookmarkContextMenu() override;

// Shows the context menu at the specified point.

void RunMenuAt(const gfx::Point& point,

@@ -58,18 +58,18 @@ class BookmarkContextMenu : public BookmarkContextMenuControllerDelegate,

void SetPageNavigator(content::PageNavigator* navigator);

// Overridden from views::MenuDelegate:

- virtual void ExecuteCommand(int command_id, int event_flags) override;

- virtual bool IsItemChecked(int command_id) const override;

- virtual bool IsCommandEnabled(int command_id) const override;

- virtual bool IsCommandVisible(int command_id) const override;

- virtual bool ShouldCloseAllMenusOnExecute(int id) override;

+ void ExecuteCommand(int command_id, int event_flags) override;

+ bool IsItemChecked(int command_id) const override;

+ bool IsCommandEnabled(int command_id) const override;

+ bool IsCommandVisible(int command_id) const override;

+ bool ShouldCloseAllMenusOnExecute(int id) override;

// Overridden from BookmarkContextMenuControllerDelegate:

- virtual void CloseMenu() override;

- virtual void WillExecuteCommand(

+ void CloseMenu() override;

+ void WillExecuteCommand(

int command_id,

const std::vector<const BookmarkNode*>& bookmarks) override;

- virtual void DidExecuteCommand(int command_id) override;

+ void DidExecuteCommand(int command_id) override;

private:

scoped_ptr<BookmarkContextMenuController> controller_;