Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h

Issue 678803003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 views::MenuItemView* context_menu() const; 68 views::MenuItemView* context_menu() const;
69 69
70 // Sets the page navigator. 70 // Sets the page navigator.
71 void SetPageNavigator(content::PageNavigator* navigator); 71 void SetPageNavigator(content::PageNavigator* navigator);
72 72
73 void set_observer(BookmarkMenuControllerObserver* observer) { 73 void set_observer(BookmarkMenuControllerObserver* observer) {
74 observer_ = observer; 74 observer_ = observer;
75 } 75 }
76 76
77 // views::MenuDelegate: 77 // views::MenuDelegate:
78 virtual base::string16 GetTooltipText(int id, 78 base::string16 GetTooltipText(int id, const gfx::Point& p) const override;
79 const gfx::Point& p) const override; 79 bool IsTriggerableEvent(views::MenuItemView* view,
80 virtual bool IsTriggerableEvent(views::MenuItemView* view, 80 const ui::Event& e) override;
81 const ui::Event& e) override; 81 void ExecuteCommand(int id, int mouse_event_flags) override;
82 virtual void ExecuteCommand(int id, int mouse_event_flags) override; 82 bool ShouldExecuteCommandWithoutClosingMenu(int id,
83 virtual bool ShouldExecuteCommandWithoutClosingMenu( 83 const ui::Event& e) override;
84 int id, 84 bool GetDropFormats(
85 const ui::Event& e) override;
86 virtual bool GetDropFormats(
87 views::MenuItemView* menu, 85 views::MenuItemView* menu,
88 int* formats, 86 int* formats,
89 std::set<ui::OSExchangeData::CustomFormat>* custom_formats) override; 87 std::set<ui::OSExchangeData::CustomFormat>* custom_formats) override;
90 virtual bool AreDropTypesRequired(views::MenuItemView* menu) override; 88 bool AreDropTypesRequired(views::MenuItemView* menu) override;
91 virtual bool CanDrop(views::MenuItemView* menu, 89 bool CanDrop(views::MenuItemView* menu,
92 const ui::OSExchangeData& data) override; 90 const ui::OSExchangeData& data) override;
93 virtual int GetDropOperation(views::MenuItemView* item, 91 int GetDropOperation(views::MenuItemView* item,
94 const ui::DropTargetEvent& event, 92 const ui::DropTargetEvent& event,
95 DropPosition* position) override; 93 DropPosition* position) override;
96 virtual int OnPerformDrop(views::MenuItemView* menu, 94 int OnPerformDrop(views::MenuItemView* menu,
97 DropPosition position, 95 DropPosition position,
98 const ui::DropTargetEvent& event) override; 96 const ui::DropTargetEvent& event) override;
99 virtual bool ShowContextMenu(views::MenuItemView* source, 97 bool ShowContextMenu(views::MenuItemView* source,
100 int id, 98 int id,
101 const gfx::Point& p, 99 const gfx::Point& p,
102 ui::MenuSourceType source_type) override; 100 ui::MenuSourceType source_type) override;
103 virtual void DropMenuClosed(views::MenuItemView* menu) override; 101 void DropMenuClosed(views::MenuItemView* menu) override;
104 virtual bool CanDrag(views::MenuItemView* menu) override; 102 bool CanDrag(views::MenuItemView* menu) override;
105 virtual void WriteDragData(views::MenuItemView* sender, 103 void WriteDragData(views::MenuItemView* sender,
106 ui::OSExchangeData* data) override; 104 ui::OSExchangeData* data) override;
107 virtual int GetDragOperations(views::MenuItemView* sender) override; 105 int GetDragOperations(views::MenuItemView* sender) override;
108 virtual views::MenuItemView* GetSiblingMenu( 106 views::MenuItemView* GetSiblingMenu(views::MenuItemView* menu,
109 views::MenuItemView* menu, 107 const gfx::Point& screen_point,
110 const gfx::Point& screen_point, 108 views::MenuAnchorPosition* anchor,
111 views::MenuAnchorPosition* anchor, 109 bool* has_mnemonics,
112 bool* has_mnemonics, 110 views::MenuButton** button) override;
113 views::MenuButton** button) override; 111 int GetMaxWidthForMenu(views::MenuItemView* view) override;
114 virtual int GetMaxWidthForMenu(views::MenuItemView* view) override;
115 112
116 // BaseBookmarkModelObserver: 113 // BaseBookmarkModelObserver:
117 virtual void BookmarkModelChanged() override; 114 void BookmarkModelChanged() override;
118 115
119 private: 116 private:
120 // BookmarkMenuController deletes itself as necessary. 117 // BookmarkMenuController deletes itself as necessary.
121 virtual ~BookmarkMenuController(); 118 ~BookmarkMenuController() override;
122 119
123 scoped_ptr<views::MenuRunner> menu_runner_; 120 scoped_ptr<views::MenuRunner> menu_runner_;
124 121
125 scoped_ptr<BookmarkMenuDelegate> menu_delegate_; 122 scoped_ptr<BookmarkMenuDelegate> menu_delegate_;
126 123
127 // The node we're showing the contents of. 124 // The node we're showing the contents of.
128 const BookmarkNode* node_; 125 const BookmarkNode* node_;
129 126
130 // Data for the drop. 127 // Data for the drop.
131 bookmarks::BookmarkNodeData drop_data_; 128 bookmarks::BookmarkNodeData drop_data_;
132 129
133 // The observer, may be null. 130 // The observer, may be null.
134 BookmarkMenuControllerObserver* observer_; 131 BookmarkMenuControllerObserver* observer_;
135 132
136 // Is the menu being shown for a drop? 133 // Is the menu being shown for a drop?
137 bool for_drop_; 134 bool for_drop_;
138 135
139 // The bookmark bar. This is only non-null if we're showing a menu item for a 136 // The bookmark bar. This is only non-null if we're showing a menu item for a
140 // folder on the bookmark bar and not for drop, or if the BookmarkBarView has 137 // folder on the bookmark bar and not for drop, or if the BookmarkBarView has
141 // been destroyed before the menu. 138 // been destroyed before the menu.
142 BookmarkBarView* bookmark_bar_; 139 BookmarkBarView* bookmark_bar_;
143 140
144 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuController); 141 DISALLOW_COPY_AND_ASSIGN(BookmarkMenuController);
145 }; 142 };
146 143
147 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_ 144 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_MENU_CONTROLLER_VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698