Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 678763008: Set minimum OS X version to 10.5.x in DevicePermissionPrompt.xib. (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set minimum OS X version to 10.5.x in DevicePermissionPrompt.xib. This resolves a number of compile-time warnings about features that are not available in versions prior to 10.5. BUG=427654 Committed: https://crrev.com/b538eb3bfd9a299885d589ca85809aa31587646e Cr-Commit-Position: refs/heads/master@{#301584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/nibs/DevicePermissionsPrompt.xib View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
6 years, 1 month ago (2014-10-28 01:59:34 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 1 month ago (2014-10-28 02:00:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678763008/1
6 years, 1 month ago (2014-10-28 02:25:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 07:08:40 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 07:09:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b538eb3bfd9a299885d589ca85809aa31587646e
Cr-Commit-Position: refs/heads/master@{#301584}

Powered by Google App Engine
This is Rietveld 408576698