Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 678763003: In SkPDFDocumentToBitmap, use SkCreateDataProviderFromStream (Closed)

Created:
6 years, 1 month ago by hal.canary
Modified:
6 years, 1 month ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

In SkPDFDocumentToBitmap, use SkCreateDataProviderFromStream CGDataProviderCreateWithData to SkCreateDataProviderFromStream in SkPDFDocumentToBitmap Committed: https://skia.googlesource.com/skia/+/c8306779b8a484ac05e84d1580c393e9e24460ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M src/utils/mac/SkCreateCGImageRef.cpp View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hal.canary
ptal
6 years, 1 month ago (2014-10-27 12:18:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678763003/1
6 years, 1 month ago (2014-10-27 12:19:11 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-27 12:19:12 UTC) #5
scroggo
lgtm
6 years, 1 month ago (2014-10-27 14:06:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 14:06:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as c8306779b8a484ac05e84d1580c393e9e24460ee

Powered by Google App Engine
This is Rietveld 408576698