Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 678753002: SimpleMove now calls [[Has]] before [[Get]] when moving elements (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

SimpleMove now calls [[Has]] before [[Get]] when moving elements BUG=v8:3643 LOG=n R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M src/array.js View 2 chunks +4 lines, -12 lines 0 comments Download
M test/mjsunit/regress/regress-3643.js View 1 chunk +19 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
6 years, 2 months ago (2014-10-24 18:44:47 UTC) #2
Michael Starzinger
LGTM. Thanks!
6 years, 1 month ago (2014-10-27 09:54:25 UTC) #3
adamk
6 years, 1 month ago (2014-10-27 13:05:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24907 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698