Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 678743002: Revert of Check in executable for iOS test launcher (Closed)

Created:
6 years, 2 months ago by jennyz
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Check in executable for iOS test launcher (patchset #7 id:110001 of https://codereview.chromium.org/669673004/) Reason for revert: This caused gclient runhooks failed with error: gyp: Dependency '/home/chrome-bot/chrome_root/src/third_party/zlib/zlib.gyp:zlib#host' not found while trying to load target /home/chrome-bot/chrome_root/src/third_party/libxml/libxml.gyp:libxml#host See the build log: http://build.chromium.org/p/chromiumos.chromium/builders/AMD64%20%28chromium%29/builds/2292/steps/cbuildbot/logs/stdio Original issue's description: > Check in executable for iOS test launcher > > This doesn't do anything yet, mostly adds supporting infrastructure. > > R=lliabraa@chromium.org, mark@chromium.org, sdefresne@chromium.org, lliabraa, mark, sdefresne > TBR=darin > > BUG=426870 > > Committed: https://chromium.googlesource.com/chromium/src/+/ec3246c03b35b330266ef3c26b651ab2f5876d19 TBR=sdefresne@chromium.org,lliabraa@chromium.org,darin@chromium.org,mark@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=426870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -67 lines) Patch
M base/base.gyp View 12 chunks +1 line, -34 lines 0 comments Download
D base/test/launcher/test_launcher_ios.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M build/android/android_exports.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/setup.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/gmock.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/jsr-305/jsr-305.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jennyz
Created Revert of Check in executable for iOS test launcher
6 years, 2 months ago (2014-10-24 18:26:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678743002/1
6 years, 2 months ago (2014-10-24 18:27:23 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 18:28:37 UTC) #4
Failed to apply patch for base/test/launcher/test_launcher_ios.cc:
While running git rm base/test/launcher/test_launcher_ios.cc;
  fatal: pathspec 'base/test/launcher/test_launcher_ios.cc' did not match any
files

Patch:  D    base/test/launcher/test_launcher_ios.cc
Index: base/test/launcher/test_launcher_ios.cc
diff --git a/base/test/launcher/test_launcher_ios.cc
b/base/test/launcher/test_launcher_ios.cc
deleted file mode 100644
index
38e4ef9aa916ceca2d49d2f043cf65c1a3d6f6c3..0000000000000000000000000000000000000000
--- a/base/test/launcher/test_launcher_ios.cc
+++ /dev/null
@@ -1,20 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/test/launcher/test_launcher.h"
-
-#include "base/bind.h"
-#include "base/test/launcher/unit_test_launcher.h"
-
-namespace {
-
-int DummyRunTestSuite(void) {
-  return -1;
-}
-
-}  // namespace
-
-int main(int argc, char** argv) {
-  return base::LaunchUnitTests(argc, argv, base::Bind(&DummyRunTestSuite));
-}

Powered by Google App Engine
This is Rietveld 408576698