Oilpan: clear FrameLoader during LocalFrame detach.

Oilpan: clear FrameLoader during LocalFrame detach.

Following r183834, the FrameOwner is disconnected during frame detach.
The clearing of the FrameLoader that needs to happen for Oilpan can
consequently be moved to a more natural place and be done as part
of the other LocalFrame detach operations (rather than being a
special action of FrameOwner disconnecting.)

R=haraken
BUG=425559
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184382

[sof, 2014-10-24 09:14:06]

sigbjornf@opera.com changed reviewers:
+ dcheng@chromium.org, oilpan-reviews@chromium.org

[sof, 2014-10-24 09:14:07]

Please take a look.

LocalFrame::detach() is now a more natural place for handling the FrameLoader
clearing.

One can argue whether this ought to happen before calling Frame::detach() or
not, but for now, delaying it until after addresses the test
discrepancy/failure.

Note: I kept the plugin element disconnection in its existing place as it
"disconnects". But no strong preference, it can be moved out also.

[haraken, 2014-10-24 13:45:39]

LGTM

[sof, 2014-10-24 20:01:05]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-10-24 20:01:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/678673002/1

[dcheng, 2014-10-24 20:03:51]

dcheng@chromium.org changed reviewers:
+ haraken@chromium.org

[dcheng, 2014-10-24 20:03:51]

https://codereview.chromium.org/678673002/diff/1/Source/core/frame/LocalFrame...
File Source/core/frame/LocalFrame.cpp (left):

https://codereview.chromium.org/678673002/diff/1/Source/core/frame/LocalFrame...
Source/core/frame/LocalFrame.cpp:289: setView(nullptr);
One quick question--is this getting handled elsewhere now? I see that we call
FrameView::clear() in FrameLoader::clear().

[sof, 2014-10-24 20:04:18]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2014-10-24 20:05:41]

https://codereview.chromium.org/678673002/diff/1/Source/core/frame/LocalFrame...
File Source/core/frame/LocalFrame.cpp (left):

https://codereview.chromium.org/678673002/diff/1/Source/core/frame/LocalFrame...
Source/core/frame/LocalFrame.cpp:289: setView(nullptr);
On 2014/10/24 20:03:51, dcheng wrote:
> One quick question--is this getting handled elsewhere now? I see that we call
> FrameView::clear() in FrameLoader::clear().

Yes, 5 lines up in LocalFrame::detach().

[sof, 2014-10-24 20:46:47]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-10-24 20:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/678673002/1

[commit-bot: I haz the power, 2014-10-24 20:48:57]

Committed patchset #1 (id:1) as 184382