Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 678653004: Revert "Check in executable for iOS test launcher" (Closed)

Created:
6 years, 2 months ago by Yaron
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Check in executable for iOS test launcher" > Check in executable for iOS test launcher > > This doesn't do anything yet, mostly adds supporting infrastructure. > > R=lliabraa@chromium.org, mark@chromium.org, sdefresne@chromium.org, lliabraa, mark, sdefresne > TBR=darin > BUG=426870 Breaks correctness of Android build: ninja: Entering directory `out-android/Debug' ninja: warning: multiple rules generate ../../build/android. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/enums/base_java_application_state/org/chromium/base/ApplicationState.java. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/jsr_305_javalib/compile.stamp. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/jsr_305_javalib/jsr_305_javalib.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/jsr_305_javalib.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/jsr_305_javalib/lint.stamp. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/jsr_305_javalib.jar.TOC. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/jsr_305_javalib.dex.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/jsr_305_javalib.dex.jar.inputs. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/enums/base_java_memory_pressure_level/org/chromium/base/MemoryPressureLevel.java. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/base_java/compile.stamp. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/base_java/base_java.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/base_java/lint.stamp. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java.jar.TOC. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java.dex.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java.dex.jar.inputs. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/base_java_unittest_support/compile.stamp. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/base_java_unittest_support/base_java_unittest_support.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java_unittest_support.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate gen/base_java_unittest_support/lint.stamp. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java_unittest_support.jar.TOC. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java_unittest_support.dex.jar. builds involving this target will not be correct; continuing anyway ninja: warning: multiple rules generate lib.java/base_java_unittest_support.dex.jar.inputs. builds involving this target will not be correct; continuing anyway [2474 3248/20791] ACTION jni_generator_py_tests: run_jni_generator_py_tests_1f564c39dcae2772599d3e8883c02764 and adds host toolset dep for Java is unintended. R=phajdan.jr@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/cb4d80cfd84967203b5881219048671910dc9b28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -67 lines) Patch
M base/base.gyp View 12 chunks +1 line, -34 lines 0 comments Download
D base/test/launcher/test_launcher_ios.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M build/android/android_exports.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/setup.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/gmock.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/jsr-305/jsr-305.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yaron
6 years, 2 months ago (2014-10-24 18:02:21 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb4d80cfd84967203b5881219048671910dc9b28 Cr-Commit-Position: refs/heads/master@{#301147}
6 years, 2 months ago (2014-10-24 18:04:18 UTC) #2
Yaron
6 years, 2 months ago (2014-10-24 18:04:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb4d80cfd84967203b5881219048671910dc9b28.

Powered by Google App Engine
This is Rietveld 408576698