components/renderer_context_menu/context_menu_delegate.h - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/renderer_context_menu/context_menu_delegate.h

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove virtual keyword when override is specified Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc ('k') | components/renderer_context_menu/render_view_context_menu_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/renderer_context_menu/context_menu_delegate.h

diff --git a/components/renderer_context_menu/context_menu_delegate.h b/components/renderer_context_menu/context_menu_delegate.h

index 57327b16cb9b084622d8941d344bbab35555c72e..f592dcc591bdbdfb690746e94c9b57f50b42a25d 100644

--- a/components/renderer_context_menu/context_menu_delegate.h

+++ b/components/renderer_context_menu/context_menu_delegate.h

@@ -7,7 +7,7 @@

#include "base/memory/scoped_ptr.h"

-class RenderViewContextMenu;

+class RenderViewContextMenuBase;

namespace content {

class WebContents;

@@ -25,12 +25,12 @@ class ContextMenuDelegate {

// Builds and returns a context menu for a context specified by |params|.

// The returned value can be used to display the context menu.

- virtual scoped_ptr<RenderViewContextMenu> BuildMenu(

+ virtual scoped_ptr<RenderViewContextMenuBase> BuildMenu(

content::WebContents* web_contents,

const content::ContextMenuParams& params) = 0;

// Displays the context menu.

- virtual void ShowMenu(scoped_ptr<RenderViewContextMenu> menu) = 0;

+ virtual void ShowMenu(scoped_ptr<RenderViewContextMenuBase> menu) = 0;

private:

DISALLOW_COPY_AND_ASSIGN(ContextMenuDelegate);