chrome/browser/ui/panels/panel_extension_browsertest.cc - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_extension_browsertest.cc

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove virtual keyword when override is specified Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm ('k') | chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_extension_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_extension_browsertest.cc b/chrome/browser/ui/panels/panel_extension_browsertest.cc

index e56b1bea9053185436c7c1de60b6778b02ab3440..957837335fa38c3569ee3a7624f2fd1ebd9ed55f 100644

--- a/chrome/browser/ui/panels/panel_extension_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_extension_browsertest.cc

@@ -123,6 +123,8 @@ class PanelContextMenu : public RenderViewContextMenu {

return menu_model_.GetIndexOfCommandId(command_id) != -1;

}

+ void Show() override {}

protected:

// RenderViewContextMenu implementation.

bool GetAcceleratorForCommandId(int command_id,