chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h - Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

Issue 678653003: Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove virtual keyword when override is specified Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc ('k') | chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

index 2a0d9d6396ab71ac9007c2c512f4b5680a30eb26..55766ce17520fd80729ad0d7ae6821c6b4cd5a32 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

@@ -14,7 +14,7 @@

#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"

#endif

-class RenderViewContextMenu;

+class RenderViewContextMenuBase;

namespace ui {

class SimpleMenuModel;

@@ -75,9 +75,9 @@ class ChromeWebViewGuestDelegate : public WebViewGuestDelegate,

// Stores the current zoom factor.

double current_zoom_factor_;

- // Holds the RenderViewContextMenu that has been built but yet to be

- // shown. This is .Reset() after ShowContextMenu().

- scoped_ptr<RenderViewContextMenu> pending_menu_;

+ // Holds the RenderViewContextMenuBase that has been built but yet to be

+ // shown. This is .reset() after ShowContextMenu().

+ scoped_ptr<RenderViewContextMenuBase> pending_menu_;

#if defined(OS_CHROMEOS)

// Subscription to receive notifications on changes to a11y settings.